Release 20251006 #328
Release 20251006 #328
Conversation
feat: Implement UseCases component and integrate task management in M…
…UsersMeCampaignsByCampaignIdPreviewQuery in AcceptedDevices, RecapBox, and Preview components
Add contract handling on manual
…for access control
…commands to SlashCommands extension
…ponents to include trailing slashes
…ling and loading state
Fix manual preview ux text
…age for handling campaign start dates
…al component logic
…complete_bonus_eur value
…aignNotStarted component
feat: Update translations for campaign status and format date in Camp…
feat: update @appquality/appquality-design-system to version 2.0.9
There was a problem hiding this comment.
Pull Request Overview
This PR implements a complete campaign preview and manual system for the Release 20251006, adding extensive functionality for users to view campaign details, apply to campaigns, and manage tasks during campaign execution.
- Adds comprehensive campaign preview pages with payout information, device compatibility, and application forms
- Implements manual/task management system with media upload capabilities and progress tracking
- Introduces new API endpoints and Redux state management for campaign tasks and media handling
Reviewed Changes
Copilot reviewed 50 out of 54 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/wpapi.ts | Adds new API endpoint for starting campaigns |
| src/store.ts | Integrates media list reducer and reorganizes imports |
| src/services/tryberApi/ | Adds cache invalidation tags for user tasks and media endpoints |
| src/pages/Profile/TabOptions/UserDeleteModal.tsx | Updates event handler parameter types from implicit to explicit any |
| src/pages/PreviewSelectionForm/ | Enhances form validation and device compatibility handling |
| src/pages/Preview/ | Complete campaign preview system with content editor and device information |
| src/pages/Manual/ | Full manual/task management system with media upload and progress tracking |
| src/pages/BugForm/FileUploader/FileCard/style.ts | Removes fixed width constraint from file card |
| src/locales/ | Adds extensive translations for preview and manual functionality |
| src/Page.tsx | Adds routing for new preview and manual pages |
| public/index.html | Adds Material Icons font support |
| package.json | Updates design system version and adds new dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| PreloadedState, | ||
| } from "@reduxjs/toolkit"; |
There was a problem hiding this comment.
[nitpick] Import ordering should be consistent. Consider grouping related imports together rather than moving PreloadedState to a different position in the middle of the import list.
| PreloadedState, | |
| } from "@reduxjs/toolkit"; | |
| } from "@reduxjs/toolkit"; | |
| import type { PreloadedState } from "@reduxjs/toolkit"; |
| if ( | ||
| form.error || | ||
| cuf.error || | ||
| (devices.error && "status" in devices.error && devices.error.status !== 404) | ||
| ) |
There was a problem hiding this comment.
The condition form.error || was removed but the comment suggests this might have been intentional. Consider adding a comment explaining why form.error checking was removed to clarify the intent.
src/pages/Manual/AcceptContract.tsx
Outdated
| <Title size="xl">Abbiamo bisogno di te!</Title> | ||
| <Title>Pronto? Inizia la Campagna</Title> |
There was a problem hiding this comment.
Hard-coded Italian text should be moved to translation files for internationalization consistency with the rest of the application.
| // @ts-ignore | ||
| body: formData, |
There was a problem hiding this comment.
Using @ts-ignore should be avoided. Consider properly typing the body parameter or using a more specific type assertion instead of suppressing TypeScript errors.
| // @ts-ignore | |
| body: formData, | |
| body: formData as any, |
| // @ts-ignore | ||
| return component?.ref?.onKeyDown?.(props) ?? false; |
There was a problem hiding this comment.
Using @ts-ignore should be avoided. Consider properly typing the component ref or using a type assertion to handle the optional chaining safely.
| // @ts-ignore | |
| return component?.ref?.onKeyDown?.(props) ?? false; | |
| // Use a type assertion to safely access onKeyDown | |
| return (component?.ref as { onKeyDown?: (props: any) => boolean })?.onKeyDown?.(props) ?? false; |
|
Currents Tests: Tryber.me tests passed after 2m 53s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
No description provided.