Skip to content

added new babel library for app engine apps and fixed all appscale api's directory layout#17

Merged
nlake44 merged 6 commits intomasterfrom
gae-babel-api
Aug 6, 2012
Merged

added new babel library for app engine apps and fixed all appscale api's directory layout#17
nlake44 merged 6 commits intomasterfrom
gae-babel-api

Conversation

@shatterednirvana
Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost assigned nlake44 Jul 31, 2012
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've gone away from naming functions with lower case and underscores. Any reason? Why not be consistent? This comment applies to other functions as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That actually was how we used to name the functions, but since I didn't use git mv, they showed up as changes. But I agree - they should be consistently named. Changed accordingly.

nlake44 added a commit that referenced this pull request Aug 6, 2012
added new babel library for app engine apps and fixed all appscale api's directory layout
@nlake44 nlake44 merged commit b859577 into master Aug 6, 2012
nlake44 added a commit to nlake44/appscale that referenced this pull request Sep 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants