Deleting cookies via the same IP they are set with#223
Merged
nlake44 merged 1 commit intoAppScale:testingfrom Jan 2, 2013
Merged
Deleting cookies via the same IP they are set with#223nlake44 merged 1 commit intoAppScale:testingfrom
nlake44 merged 1 commit intoAppScale:testingfrom
Conversation
ghost
assigned
Contributor
|
Looks good. Requesting demo. |
nlake44
added a commit
that referenced
this pull request
Jan 2, 2013
Deleting cookies via the same IP they are set with
Contributor
|
Demo'ed and looks good. |
nlake44
added a commit
to nlake44/appscale
that referenced
this pull request
Sep 30, 2013
…balancer-to-appdashboard renamed apploadbalancer to appdashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookies were being created with the public IP address and deleted via the private IP address. If these IPs are the same, this is not an issue, but in VirtualBox and EC2 (and certain types of Euca deployments), this is not true and thus can the cookie won't be deleted. Remedied this problem by always deleting via the public IP address.
This fixes issue #79. Tested on VirtualBox. To test, spawn a one node deployment on VirtualBox (with more than one eth device) or EC2 and upload the guestbook application. Log in as the admin user and log out. Then post to the guestbook app. Before this fix, you would still see your posts under your admin user account. After this fix, you see the posts performed anonymously.