Skip to content

TaskQueue reconnect and exception handling#76

Merged
shatterednirvana merged 2 commits intoAppScale:testingfrom
nlake44:tq_connect2
Oct 25, 2012
Merged

TaskQueue reconnect and exception handling#76
shatterednirvana merged 2 commits intoAppScale:testingfrom
nlake44:tq_connect2

Conversation

@nlake44
Copy link
Copy Markdown
Contributor

@nlake44 nlake44 commented Oct 24, 2012

Added fixes to the Python AppServer so that it doesn't crash if the Task Queue API implementation (currently RabbitMQ) isn't available, and increased logging for those scenarios.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of comment is not helpful. What is this the maximum waiting time for? Connecting to RabbitMQ? Sending messages? Everything? Are there implications to setting this value too low or too high? These are the types of questions that should be answered by a helpful docstring.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this MAX_WAIT is for. Leaving in for backward compatibility.

shatterednirvana added a commit that referenced this pull request Oct 25, 2012
TaskQueue reconnect and exception handling
@shatterednirvana shatterednirvana merged commit 1edf405 into AppScale:testing Oct 25, 2012
nlake44 added a commit to nlake44/appscale that referenced this pull request Sep 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants