Fix Kotlin warnings and make rating summary locale-safe#49
Closed
AppsTRDesign wants to merge 1 commit intomainfrom
Closed
Fix Kotlin warnings and make rating summary locale-safe#49AppsTRDesign wants to merge 1 commit intomainfrom
AppsTRDesign wants to merge 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Intfields causing redundant expressions.NumberFormatExceptionwhen displaying rounded ratings in locales that use comma as decimal separator.totalvalues consistently to downstream screens.Description
totalinCategoryScreen.ktandHomeScreen.kt, passing thetotaldirectly via navigation parameters usingcategory.totalinstead ofcategory.total ?: 0to silence warnings and keep semantics.PlaceDetailScreen.ktby computing a roundedDouble(avgRounded = kotlin.math.round(avg * 10.0) / 10.0) and returning it directly instead of formatting to a string and parsing back, avoiding locale-dependent parsing errors.averagevalue (roundedDouble) frombuildRatingSummaryso the Compose UI no longer attempts to parse locale-formatted numbers.Testing
Codex Task