Refactor: spring clean up 🧹#18
Merged
vituri merged 5 commits intofeat/add-config-themingfrom May 9, 2025
Merged
Conversation
DeepanshKhurana
approved these changes
Apr 12, 2025
Collaborator
DeepanshKhurana
left a comment
DeepanshKhurana
left a comment
There was a problem hiding this comment.
Hey! Thank you for this update. It does clean things up in terms of how the data flows around the app. There is one small comment for the explicit return statements which don't play well with the new lintr defaults. Besides that, LGTM!
…refactor/simplify-state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A spring clean up:
state(reactiveValues) in favor of simple reactives that are returned from modulesrenderUIs fromobserveEventsThe goal is to make further changes a bit simpler to implement