feat: support Ubuntu 24.04 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koralowiec
force-pushed
the
feat/ubuntu-2404-support
branch
from
12acd35 to
1068559
Compare
| platforms: | ||
| - &instance | ||
| name: instance-r | ||
| image: "geerlingguy/docker-${MOLECULE_DISTRO:-ubuntu2004}-ansible:latest" |
Contributor
There was a problem hiding this comment.
are we keeping test with ubuntu2004?
Contributor
Author
There was a problem hiding this comment.
The tests in CI are run for 20.04, 22.04 and 24.04. I think it doesn't matter that much what's the default here. When testing changes locally I typically run the tests against the newest and the oldest Ubuntu release
| platform: linux/amd64 | ||
| - <<: *instance | ||
| name: instance-r-rh | ||
| image: "registry.access.redhat.com/${MOLECULE_DISTRO:-ubi8}/ubi-init" |
Contributor
There was a problem hiding this comment.
why reverting test to rhel8?
Contributor
Author
There was a problem hiding this comment.
I probably reverted that by accident, but similarly to this #18 (comment) - In CI we run the tests against both releases, so the default here is not so important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the meta file and CI workflow, so Ubuntu 24.04 is officially supported by the role
Definition of Done
R CMD check, linter, unit tests, spelling)..Rdfiles withroxygen2::roxygenise())