Skip to content

fix: make dropdown work with a singular choice#61

Merged
jakubnowicki merged 2 commits intomainfrom
60-fix-single-choice-dropdown
Oct 29, 2024
Merged

fix: make dropdown work with a singular choice#61
jakubnowicki merged 2 commits intomainfrom
60-fix-single-choice-dropdown

Conversation

@TymekDev
Copy link
Copy Markdown

@TymekDev TymekDev commented Aug 5, 2024

Issue #60

Description

Prior to this change a singular value wasn't serialized as an array. This lead to JS errors when trying to set options.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@TymekDev TymekDev requested a review from jakubnowicki August 5, 2024 13:08
Copy link
Copy Markdown
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubnowicki jakubnowicki merged commit eab4a03 into main Oct 29, 2024
@jakubnowicki jakubnowicki deleted the 60-fix-single-choice-dropdown branch October 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants