Support accessor set input#62
Merged
Merged
Conversation
kamilzyla
requested changes
Jan 24, 2023
Contributor
Author
|
I believe I resolved all your comments @kamilzyla
Please take a look at the changes I did to I'm a bit ashamed of the time it took to figure out a bug I was having with |
kamilzyla
requested changes
Jan 26, 2023
Collaborator
kamilzyla
left a comment
kamilzyla
left a comment
There was a problem hiding this comment.
Great job! Have a bunch more comments, mostly nitpicks about documentation 😉
Thanks @kamilzyla Co-authored-by: Kamil Zyla <kamil@appsilon.com>
Contributor
Author
|
I dropped the ball on the documentation. Thank you for catching it! |
kamilzyla
approved these changes
Jan 27, 2023
Collaborator
kamilzyla
left a comment
kamilzyla
left a comment
There was a problem hiding this comment.
LGTM 👍 Great job and thanks for your patience 😃 🎉 Merging with a tiny docs change of mine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
setInput()#43.Changes description (include a screenshot if applicable!)
setInputDefinition of Done checklist
🗒️ README, other documentation and code comments that we have is updated with all information related to the change.
Unit tests added for all new or changed logic.
End-to-end tests added for all new or changed logic.