Fix NOTEs after win-devel R CMD CHECK#84
Merged
Merged
Conversation
95be8ae to
e46a561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve NOTES after running win-devel check.
Changes
Before
* using log directory 'd:/RCompile/CRANguest/R-devel/shiny.react.Rcheck' * using R Under development (unstable) (2024-05-16 r86559 ucrt) * using platform: x86_64-w64-mingw32 * R was compiled by gcc.exe (GCC) 13.2.0 GNU Fortran (GCC) 13.2.0 * running under: Windows Server 2022 x64 (build 20348) * using session charset: UTF-8 * checking for file 'shiny.react/DESCRIPTION' ... OK * this is package 'shiny.react' version '0.4.0' * package encoding: UTF-8 * checking CRAN incoming feasibility ... [11s] NOTE Maintainer: 'Jakub Sobolewski 'New maintainer:
Jakub Sobolewski jakub.sobolewski@appsilon.com
Old maintainer(s):
Kamil Żyła opensource+kamil@appsilon.com
Found export directive that requires package 'methods':
'exportMethods'
Remove all such namespace directives (if obsolete) or ensure that the
DESCRIPTION Depends or Imports field contains 'methods'.
Running 'testthat.R'
Status: 2 NOTEs
After
* using log directory 'd:/RCompile/CRANguest/R-devel/shiny.react.Rcheck' * using R Under development (unstable) (2024-05-16 r86559 ucrt) * using platform: x86_64-w64-mingw32 * R was compiled by gcc.exe (GCC) 13.2.0 GNU Fortran (GCC) 13.2.0 * running under: Windows Server 2022 x64 (build 20348) * using session charset: UTF-8 * checking for file 'shiny.react/DESCRIPTION' ... OK * this is package 'shiny.react' version '0.4.0' * package encoding: UTF-8 * checking CRAN incoming feasibility ... [10s] NOTE Maintainer: 'Jakub Sobolewski 'New maintainer:
Jakub Sobolewski jakub.sobolewski@appsilon.com
Old maintainer(s):
Kamil Żyła opensource+kamil@appsilon.com
Running 'testthat.R'
Status: 1 NOTE