Conversation
There was a problem hiding this comment.
Pull request overview
Release 1.0.14 업데이트로, My Collection의 일기 수정(편집) 화면 전환/데이터 갱신 이슈를 완화하고 앱 버전 정보를 올리는 변경입니다.
Changes:
MyCollectionView에서 상세 화면 라우팅 시 초기DiaryFeedModel을 함께 전달하도록 변경해, 목록 갱신 중에도 상세 화면이 안정적으로 렌더링되도록 개선MyCollectionDiary의 저장(수정) 처리 흐름을 단순화(성공 여부 분기 로직 변경)- Xcode 프로젝트의
MARKETING_VERSION/CURRENT_PROJECT_VERSION를 1.0.14 / 14로 업데이트
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| KillingPart/Views/Screens/Main/My/MyCollection/[diaryId]/MyCollectionDiary.swift | 수정 저장 시 성공 분기 처리 로직 변경(현재 성공 시 후속 동작 없음) |
| KillingPart/Views/Screens/Main/My/MyCollection/MyCollectionView.swift | Navigation 라우트에 initialDiary를 포함해 상세 화면 구성 안정화 |
| KillingPart.xcodeproj/project.pbxproj | 앱 버전/빌드 넘버 1.0.14 / 14로 업데이트 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if isSuccess { | ||
| onDiaryChanged?(diaryId) | ||
| } | ||
| guard isSuccess else { return } |
There was a problem hiding this comment.
submitEdit() 성공 여부를 guard로 확인하지만 성공 시 수행하는 동작이 현재 비어 있습니다. 성공 시 부모 화면 갱신을 위해 onDiaryChanged를 호출하려는 의도였다면 다시 호출을 추가하고, 의도가 아니라면 결과 값을 저장/guard 하는 부분을 제거해서 단순히 await viewModel.submitEdit()로 정리하는 편이 유지보수에 좋습니다.
Suggested change
| guard isSuccess else { return } | |
| guard isSuccess else { return } | |
| onDiaryChanged?(diaryId) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
업데이트 내용