Conversation
There was a problem hiding this comment.
Pull request overview
Adds Google social login to the iOS authentication flow alongside the existing social providers.
Changes:
- Adds a Google login button to the login screen and wires it into
LoginViewModel. - Implements Google Sign-In token acquisition in
AuthServiceand backend exchange via/oauth2/google. - Registers the Google OAuth app configuration, icon asset, and Swift package dependencies needed for the feature.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
KillingPart/Views/Screens/Auth/LoginView.swift |
Adds the Google login button to the auth UI and comments out the demo login button. |
KillingPart/Views/Screens/Auth/Components/GoogleLoginButton.swift |
Introduces a reusable Google social login button component. |
KillingPart/ViewModels/LoginViewModel.swift |
Adds Google as a social provider and implements the Google login flow. |
KillingPart/Services/AuthService.swift |
Integrates the GoogleSignIn SDK and extracts the Google ID token. |
KillingPart/Services/AuthenticationService.swift |
Adds the API call for backend Google social login. |
KillingPart/Models/AuthModel.swift |
Defines the Google login request payload model. |
KillingPart/KillingPartApp.swift |
Handles Google OAuth callback URLs at the app entry point. |
KillingPart/Info.plist |
Registers Google URL schemes and client IDs in app configuration. |
KillingPart/Assets.xcassets/ic_google.imageset/Contents.json |
Adds asset catalog metadata for the Google login icon. |
KillingPart.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved |
Locks new package dependencies required for Google Sign-In. |
KillingPart.xcodeproj/project.pbxproj |
Adds Google Sign-In package products/frameworks and updates project versioning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+70
to
+74
| // Button(action: viewModel.loginWithTester) { | ||
| // ZStack { | ||
| // Text("체험하기(Demo)") | ||
| // .font(AppFont.paperlogy5Medium(size: 14)) | ||
| // .opacity( |
| throw AuthServiceError.googlePresentationAnchorUnavailable | ||
| } | ||
|
|
||
| do { |
Comment on lines
+49
to
+52
| <key>GIDClientID</key> | ||
| <string>619615909665-c9j3gs1vqmvi64rhb9i9ikg6dnpdghc0.apps.googleusercontent.com</string> | ||
| <key>GIDServerClientID</key> | ||
| <string>619615909665-o6l3i6de7i7l1msfjrvl9qu43scp08bj.apps.googleusercontent.com</string> |
Comment on lines
+99
to
+107
| func loginWithGoogle() { | ||
| guard startSocialLogin(for: .google) else { return } | ||
|
|
||
| Task { | ||
| defer { finishSocialLogin() } | ||
|
|
||
| do { | ||
| let googleIDToken = try await authService.loginWithGoogle() | ||
| let response = try await authenticationService.loginWithGoogle(idToken: googleIDToken) |
Comment on lines
+156
to
+157
| 1260BBC52FA88B900006BF01 /* GoogleSignIn */, | ||
| 1260BBC72FA88B900006BF01 /* GoogleSignInSwift */, |
mark77234
added a commit
that referenced
this pull request
May 9, 2026
* feat - 푸시알림 작업 (#80) * feat(FCM): FCM Token 발급 및 등록/삭제 API 연동 * fix(FCM): 기존 컨벤션 적용 * fix(fcm): 테스트버전 체크 * feat - 구글로그인 추가 (#83) * feat(Google): 구글로그인 추가 * feat(1.1.10): 버전 업데이트 * Feat/82 (#84) * fix(ProfileCard): Tag, StatItem FixedSize Added * feat(Settings): 프로필 설정 섹션 -> 프로필 페이지로 마이그레이션 * feat(Setting): 디자인 업데이트 * feat(Setting): NameEdit, TagEdit UI Update and SettingsView Space Added * feat(Block): Block Api Settings * feat(Blocklist): 차단 목록 추가 및 차단 해제 API 추가 및 연동 및 페이지 추가 * feat: 다이얼로그, 바텀시트 디자인 업데이트 * feat(AppInfo,Account): 앱 정보 섹션 및 계정 섹션 추가 * feat(Settings): 카드 크기 동일하게 구현 * feat(Survey): 문의 카드 추가 * feat(Survey): 문의 카드 디자인 개선 * feat(Notification): 알림설정 추가 * feat(Settings): 차단리스트, 이름설정, 프로필이미지, 태그설정 페이지 헤더 크기 줄이기 * feat(Noti): 알림카드 세로여백 조정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용