feat(i18n): add zh-TW (Traditional Chinese, Taiwan) locale#57
Merged
Merged
Conversation
|
You've hit your limit · resets 5pm (UTC)
|
AprilNEA
requested changes
Jun 1, 2026
Owner
AprilNEA
left a comment
There was a problem hiding this comment.
Thanks for adding zh-TW. I think this needs a small follow-up before merging: clippy is currently failing, and there are a couple of i18n edge cases/comments to fix inline.
3aaee91 to
189a451
Compare
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — first Pullfrog pass on this PR; the force-pushed commit folds in fixes for all three of AprilNEA's prior threads on i18n.rs.
- Rewrote
match_supported'szharm as a single-pass script/region scan — clears theVec-allocation clippy lint and expresses resolution priority explicitly:Hans→zh-CN,hk/moregion →zh-HK,twregion or bareHant→zh-TW, fallback →zh-CN. - Documented the resolution order on
match_supported— including the corner case thatzh-Hans-HKstays Simplified (script wins) whilezh-Hant-HKresolves to HK (region wins over genericHant). - Corrected the
SUPPORTEDdoc comment —zh-TWis not ingpui-component's bundledui.yml, so it's listed alongsideja/ruas locales where framework widget strings fall back to English. - Expanded
match_supportedtests — addedzh-Hans-HK,zh-Hant-TW,zh-TW,zh-Hant, andzh-Hant-HKcases covering all four match arms. - Added
zh-TWcoverage tolocale_file_resolves_keys— assertsSettings,Left Click, the interpolatedBind %{name}, and aBLURBfallback check so a missing/typoedzh-TWcolumn would fail in CI. - Renamed the picker labels for disambiguation —
zh-HK→繁體中文(香港),zh-TW→正體中文(臺灣), using Taiwan's preferred正體term. - Added
zh-TW:translations acrosslocales/app.yml— every previously translated key now has a Taiwan-flavor column.
Claude Opus | 𝕏
AprilNEA
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request adds support for Traditional Chinese (Taiwan) as a separate locale (
zh-TW), improves locale detection logic for Chinese variants, and updates translation files and documentation accordingly.The changes ensure users can explicitly select between Simplified Chinese (
zh-CN), Traditional Chinese for Hong Kong (zh-HK), and Traditional Chinese for Taiwan (zh-TW), and that the correct translations are loaded based on their system or user-selected locale.