remove old UNIX-specific Makefile#313
Merged
christian-rauch merged 1 commit intoAprilRobotics:masterfrom Jan 31, 2024
Merged
Conversation
wxmerkt
reviewed
Jan 26, 2024
Collaborator
wxmerkt
left a comment
There was a problem hiding this comment.
I am okay with this since it's out of sync with the CMake and leads to different behaviour. We may want to highlight explicitly in CHANGELOG and in the version bump that it's been removed in case some downstream workflow dependent on it without explicit version tagging (e.g. off master)
533b5e2 to
8bb2178
Compare
8bb2178 to
91aa0d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to remove the Makefile since:
Also see the discussion here: #210.