Skip to content

Reopen pull request #395#396

Merged
christian-rauch merged 2 commits intoAprilRobotics:masterfrom
MqCreaple:pull-request
Aug 13, 2025
Merged

Reopen pull request #395#396
christian-rauch merged 2 commits intoAprilRobotics:masterfrom
MqCreaple:pull-request

Conversation

@MqCreaple
Copy link
Contributor

No description provided.

@christian-rauch
Copy link
Collaborator

Is this #395 with the comments in there addressed here?

@MqCreaple
Copy link
Contributor Author

Yes. I separated the modification on the original image_u8_convolve_2D into a separate commit. I also removed the commented-out code in apriltag.c.

@christian-rauch christian-rauch self-requested a review August 8, 2025 14:55
Copy link
Collaborator

@christian-rauch christian-rauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I only have one minor comment about the included header left. Please make these changes to the respective commit and force push to this same PR branch again.

@christian-rauch
Copy link
Collaborator

Can you squash your fixup commit (742feac) into the multithreading implementation (340b496)? Once this is done, trigger a re-review and I can then run the CI pipeline again and merge this.

@MqCreaple
Copy link
Contributor Author

May I confirm if this commit is able to merge?

@christian-rauch
Copy link
Collaborator

May I confirm if this commit is able to merge?

You did not request a review. Therefore, I did not receive a notification about this. I will have a look now.

@christian-rauch
Copy link
Collaborator

May I confirm if this commit is able to merge?

You did not request a review. Therefore, I did not receive a notification about this. I will have a look now.

No, sorry. You did request a review :-) It just went unnoticed.

Copy link
Collaborator

@christian-rauch christian-rauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@christian-rauch christian-rauch merged commit a53b368 into AprilRobotics:master Aug 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants