Skip to content

[Samples] Add missing AdvancedImagingTest sample files, and update the Python one. (CAP-1065)#146

Merged
overocean merged 2 commits intonext_releasefrom
dan/adv_img_samples
Jan 29, 2025
Merged

[Samples] Add missing AdvancedImagingTest sample files, and update the Python one. (CAP-1065)#146
overocean merged 2 commits intonext_releasefrom
dan/adv_img_samples

Conversation

@overocean
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Samples/AdvancedImagingTest/PYTHON/AdvancedImagingTest.py Outdated
at https://dev.apryse.com/. If you have already downloaded this
module, ensure that the SDK is able to find the required files
using the PDFNet::AddResourceSearchPath() function.""")
at https://docs.apryse.com/documentation/core/info/modules/. If you have already
Copy link
Copy Markdown
Contributor

@myang-apryse myang-apryse Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wana include the anchor (#advanced-imaging-module):
https://docs.apryse.com/core/guides/info/modules#advanced-imaging-module

inputFileName1 = "xray.dcm"
outputFileName1 = inputFileName1 + ".pdf"
doc1 = PDFDoc()
Convert.FromDICOM(doc1, input_path + inputFileName1, None)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor:
I'm looking at AdvancedImagingTest.cpp,
and it uses options, e.g. opts.SetDefaultDPI(72);

we should probably make them consistent across samples as much as possible (either change cpp or change this one),
as long as the option is available in both interfaces.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, AdvancedImagingConvertOptions is not exposed for these wrappers.

outputFileName1 = inputFileName1 + ".pdf"
doc1 = PDFDoc()
Convert.FromDICOM(doc1, input_path + inputFileName1, None)
doc1.Save(output_path + outputFileName1, 0)
Copy link
Copy Markdown
Contributor

@myang-apryse myang-apryse Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, the cpp uses e_linearized, not sure if it matters
(e.g. I know that e_remove_unused is sometimes actually relevant)

Copy link
Copy Markdown
Contributor

@myang-apryse myang-apryse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments about general consistency across test files.
I did not highlight every instance, if changes made, please do so consistently in bulk.

@overocean overocean merged commit 0125d73 into next_release Jan 29, 2025
@overocean overocean deleted the dan/adv_img_samples branch January 29, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants