[Samples] Add missing AdvancedImagingTest sample files, and update the Python one. (CAP-1065)#146
Conversation
| at https://dev.apryse.com/. If you have already downloaded this | ||
| module, ensure that the SDK is able to find the required files | ||
| using the PDFNet::AddResourceSearchPath() function.""") | ||
| at https://docs.apryse.com/documentation/core/info/modules/. If you have already |
There was a problem hiding this comment.
might wana include the anchor (#advanced-imaging-module):
https://docs.apryse.com/core/guides/info/modules#advanced-imaging-module
| inputFileName1 = "xray.dcm" | ||
| outputFileName1 = inputFileName1 + ".pdf" | ||
| doc1 = PDFDoc() | ||
| Convert.FromDICOM(doc1, input_path + inputFileName1, None) |
There was a problem hiding this comment.
minor:
I'm looking at AdvancedImagingTest.cpp,
and it uses options, e.g. opts.SetDefaultDPI(72);
we should probably make them consistent across samples as much as possible (either change cpp or change this one),
as long as the option is available in both interfaces.
There was a problem hiding this comment.
Unfortunately, AdvancedImagingConvertOptions is not exposed for these wrappers.
| outputFileName1 = inputFileName1 + ".pdf" | ||
| doc1 = PDFDoc() | ||
| Convert.FromDICOM(doc1, input_path + inputFileName1, None) | ||
| doc1.Save(output_path + outputFileName1, 0) |
There was a problem hiding this comment.
similarly, the cpp uses e_linearized, not sure if it matters
(e.g. I know that e_remove_unused is sometimes actually relevant)
myang-apryse
left a comment
There was a problem hiding this comment.
Made some comments about general consistency across test files.
I did not highlight every instance, if changes made, please do so consistently in bulk.
No description provided.