Add support for client-side certificates #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing in the
certparameter to the session object (through theAikidoSessionclass).I hope adding a new headline (with a new version number) to
CHANGELOG.rstwas the right move here. LMK if I should do this differently.Limitations:
grequestswell enough to add this feature there as well. But I think throwing an exception in that case is better than not having client-side certificate support at all).testsdirectory but don't really know where I would add a test for a feature like this. Would it be ok to merge this even though theCONTRIBUTING.mdstates that