Add Gst 10/12/14/16-bit support#1059
Merged
EmmanuelP merged 2 commits intoAravisProject:mainfrom Mar 13, 2026
Merged
Conversation
EmmanuelP
requested changes
Mar 13, 2026
Contributor
EmmanuelP
left a comment
There was a problem hiding this comment.
Thanks a lot. Just 2 minor things to fix.
GStreamer 1.24 added support into bayer2rgb.
Contributor
|
Thanks for your investigation about g_strdup_printf. In the absence of a corresponding test in glib test suite, you are right it is better to take care to not send a NULL string parameter. |
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GStreamer 1.24 added support for more bit depths into bayer2rgb.
I only had Basler acA2440-20gc that implements BayerRG12. I tested on Testimage3 (for all pixel values) and Testimage6 (for correct colors) with command
I also noticed a small potential leak in error path.