Conversation
…ne geometric mean
…complete git history of pdex2 into this repository.
Integrate pdex2
Feat/backed adata
Summary of ChangesHello @noamteyssier, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a major refactoring and version bump to 0.2.0. The core logic has been completely rewritten into a more streamlined API with the pdex() function and its different modes (ref, all, on_target). The implementation is simplified, removing the pydeseq2 dependency in favor of numba-mwu for Mann-Whitney U tests, and replacing the manual shared-memory multiprocessing with Numba's threading capabilities. The documentation and test suite have also been significantly improved. My review identifies a critical issue with dependency versions in pyproject.toml that will prevent installation, and some minor documentation inconsistencies regarding FDR calculation that could be clarified for users.
| "anndata>=0.12.10", | ||
| "numba>=0.64.0", | ||
| "numba-mwu>=0.1.1", | ||
| "numpy>=2.4.2", | ||
| "pandas>=2.3.3", | ||
| "polars>=1.38.1", | ||
| "pyarrow>=23.0.1", | ||
| "scipy>=1.17.1", | ||
| "tqdm>=4.67.3", |
There was a problem hiding this comment.
The version specifiers for several dependencies appear to be for future, unreleased versions. For example, numpy>=2.4.2, pandas>=2.3.3, polars>=1.38.1, anndata>=0.12.10, etc., are not available on PyPI. This will cause installation to fail for users.
Please correct these to valid, available versions. You might want to use the latest stable versions or a less restrictive specifier like >= with a known good version (e.g., numpy>=2.0.0).
| "anndata>=0.12.10", | |
| "numba>=0.64.0", | |
| "numba-mwu>=0.1.1", | |
| "numpy>=2.4.2", | |
| "pandas>=2.3.3", | |
| "polars>=1.38.1", | |
| "pyarrow>=23.0.1", | |
| "scipy>=1.17.1", | |
| "tqdm>=4.67.3", | |
| "anndata>=0.10.0", | |
| "numba>=0.59.0", | |
| "numba-mwu>=0.1.1", | |
| "numpy>=2.0.0", | |
| "pandas>=2.2.0", | |
| "polars>=0.20.0", | |
| "pyarrow>=16.0.0", | |
| "scipy>=1.13.0", | |
| "tqdm>=4.66.0", |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
close #67
close #66
close #65
close #52
close #51
close #46
close #18
close #9