Comprehensive Update: Linting, Configuration, and Dependency Enhancements#3
Merged
factman merged 1 commit intoArcStackLab:mainfrom Sep 22, 2024
Merged
Comprehensive Update: Linting, Configuration, and Dependency Enhancements#3factman merged 1 commit intoArcStackLab:mainfrom
factman merged 1 commit intoArcStackLab:mainfrom
Conversation
NX lint, Eslint, tsconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.eslintrc.jsonfile.index.tsfile to export all entities from@arcstack/permissions/src/PermissionsAPI.nx.json.pnpm-lock.yaml.tsconfig.base.json.tsconfig.jsonextending fromtsconfig.base.json.Solution
.eslintrc.jsonfile..vscode/settings.jsonto include the TypeScript SDK path and added JSON schema configuration fortsup.index.tsfile to export all entities from@arcstack/permissions/src/PermissionsAPI.nx.jsonto include targetDefaults for build with dependencies on "^build" and "lint", and specified outputs and caching. AddednxCloudIdand updatednxCloudAccessToken.package.jsonwith new name, version, module, types, entry points, andtsupconfiguration. Added new scripts for prebuild, build, and updated lint script. Modified devDependencies versions for eslint, nx, esbuild, husky, lint-staged, typescript, tslib, and addedtsup.pnpm-lock.yamlto newer versions and removed unnecessary packages while adding new ones.tsconfig.base.jsonwith relevant TypeScript options and changed target and module settings.tsconfig.jsonfile extending fromtsconfig.base.json.Test results
Add your screenshots or recording about testing
Other changes
Deploy Notes
There are no new dependencies, scripts, or environment variables introduced with this PR.
New dev dependencies:
tsup: Added for bundling TypeScript files.