Skip to content

Comprehensive Update: Linting, Configuration, and Dependency Enhancements#3

Merged
factman merged 1 commit intoArcStackLab:mainfrom
factman:genesis
Sep 22, 2024
Merged

Comprehensive Update: Linting, Configuration, and Dependency Enhancements#3
factman merged 1 commit intoArcStackLab:mainfrom
factman:genesis

Conversation

@factman
Copy link
Copy Markdown
Contributor

@factman factman commented Sep 22, 2024

Status Type Env Vars Change
Ready Feature/Tooling No

Problem

  • Missing newline at the end of .eslintrc.json file.
  • Lack of TypeScript SDK path and JSON schema configuration in VS Code settings.
  • Absence of a main index.ts file to export all entities from @arcstack/permissions/src/PermissionsAPI.
  • Missing targetDefaults for build and lint in nx.json.
  • Outdated package.json scripts and dependencies.
  • Outdated dependencies in pnpm-lock.yaml.
  • Outdated and missing options in tsconfig.base.json.
  • Missing tsconfig.json extending from tsconfig.base.json.

Solution

  • Added the missing newline at the end of the .eslintrc.json file.
  • Updated .vscode/settings.json to include the TypeScript SDK path and added JSON schema configuration for tsup.
  • Created a new index.ts file to export all entities from @arcstack/permissions/src/PermissionsAPI.
  • Updated nx.json to include targetDefaults for build with dependencies on "^build" and "lint", and specified outputs and caching. Added nxCloudId and updated nxCloudAccessToken.
  • Updated package.json with new name, version, module, types, entry points, and tsup configuration. Added new scripts for prebuild, build, and updated lint script. Modified devDependencies versions for eslint, nx, esbuild, husky, lint-staged, typescript, tslib, and added tsup.
  • Updated various dependencies in pnpm-lock.yaml to newer versions and removed unnecessary packages while adding new ones.
  • Updated tsconfig.base.json with relevant TypeScript options and changed target and module settings.
  • Added a new tsconfig.json file extending from tsconfig.base.json.

Test results

Add your screenshots or recording about testing

Other changes

  • None

Deploy Notes

There are no new dependencies, scripts, or environment variables introduced with this PR.

New dev dependencies:

  • tsup : Added for bundling TypeScript files.

@factman factman self-assigned this Sep 22, 2024
@factman factman merged commit 0c8899b into ArcStackLab:main Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant