Skip to content

Conversation

@EricGustin
Copy link
Member

The linter thinks that I was using an html tag. Updated so that it is happy and the build passes.

@@ -1,3 +1,3 @@
# Arcade <toolkit-name> Toolkit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not want some sort of indication for placeholders?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would you suggest? The prod build is failing because of the previous placeholder <>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does escaping the carats work? \<

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&lt and &gt would work, but I will just opt for UPPER-CASE as an indication for placeholder.

@EricGustin EricGustin requested a review from sdreyer February 27, 2025 18:45
Copy link
Contributor

@sdserranog sdserranog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EricGustin EricGustin merged commit f06f3d5 into main Feb 27, 2025
1 check passed
@EricGustin EricGustin deleted the ericgustin/fix-unintentional-html-tag branch February 27, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants