Fix dict args in Hubspot Events Api tools #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes six HubSpot Events API tools that relied on complex object arguments due to limitations in the current Moar framework's handling of such structures. The version has been bumped to 1.0.0 to reflect this breaking change.
- Removed six tool definitions and their implementations that couldn't be properly supported
- Updated tool descriptions and parameter names in the Moar configuration for the remaining retrieve_event_completions tool
- Cleaned up unused imports and validation logic
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bumped from 0.1.0 to 1.0.0 |
| UpdateEventProperty.json | Removed tool definition for updating event properties |
| SendEventData.json | Removed tool definition for sending single event data |
| SendBatchEvents.json | Removed tool definition for sending batch events |
| RetrieveEventCompletions.json | Removed tool definition (now defined in Python code) |
| CreateEventProperty.json | Removed tool definition for creating event properties |
| CreateCustomEventDefinition.json | Removed tool definition for creating custom events |
| tools/init.py | Removed six tool implementations, schema validation logic, and unused imports |
| Hubspot_Events.json | Updated parameter names and descriptions for retrieve_event_completions tool |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Re-raise for 4xx errors or if max retries reached | ||
| raise | ||
| except httpx.RequestError: | ||
| except httpx.RequestError as e: |
There was a problem hiding this comment.
The exception variable e is caught but never used. Either remove the variable binding or utilize it in error handling/logging.
Suggested change
| except httpx.RequestError as e: | |
| except httpx.RequestError: |
jottakka
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Six tools had to be removed because our current strategies to handle complex object arguments aren't sufficient. It is technically possible to support those (uncommon) cases, but it will require non-trivial refactoring in Moar complex-objects handling logic. Decided to leave this for a future Moar enhancement.