Skip to content

Support comments on exported constructors#91

Merged
ArcadeMode merged 14 commits intomasterfrom
copilot/add-commentinfo-to-constructorinfo
Mar 1, 2026
Merged

Support comments on exported constructors#91
ArcadeMode merged 14 commits intomasterfrom
copilot/add-commentinfo-to-constructorinfo

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

#87

  • Add Comment property to ConstructorInfo
  • Update ConstructorInfoBuilder to build comment from constructor symbol, passing initializersObjectParameter
  • Update TypeScriptMethodRenderer.RenderProxyConstructor to render JSDoc
  • Update all test baselines for constructors with initializer objects to include the injected JSDoc block
  • Add 5 constructor JSDoc tests including one for a class with a public get; set; property verifying the injected @param jsObject
Original prompt

add commentinfo to the constructorinfo class. add it to the typeshim proxy renderer to render it on the proxy constructor.

add generator unit tests fora few cases like

  • simple comment with some formats
  • comment with params
  • comment with remark
  • comment with exception

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 28, 2026 22:07
Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
Copilot AI changed the title [WIP] Add commentInfo to ConstructorInfo class and proxy renderer Add CommentInfo to ConstructorInfo and render JSDoc on proxy constructor Feb 28, 2026
@ArcadeMode ArcadeMode changed the title Add CommentInfo to ConstructorInfo and render JSDoc on proxy constructor Support comments on exported constructors Feb 28, 2026
@github-actions
Copy link

github-actions bot commented Feb 28, 2026

Test Results

    9 files  ±0     65 suites  ±0   30s ⏱️ -3s
  681 tests +5    677 ✅ +5   4 💤 ±0  0 ❌ ±0 
1 881 runs  +5  1 856 ✅ +5  25 💤 ±0  0 ❌ ±0 

Results for commit 2069c7d. ± Comparison against base commit e536c64.

♻️ This comment has been updated with latest results.

Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
@ArcadeMode ArcadeMode marked this pull request as ready for review February 28, 2026 22:28
@github-actions
Copy link

github-actions bot commented Feb 28, 2026


BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.103
  [Host]     : .NET 10.0.3 (10.0.3, 10.0.326.7603), X64 RyuJIT x86-64-v4
  Job-MLTFGY : .NET 10.0.3 (10.0.3, 10.0.326.7603), X64 RyuJIT x86-64-v4

InvocationCount=1  IterationCount=1  LaunchCount=10  
RunStrategy=ColdStart  UnrollFactor=1  WarmupCount=0  

Method Compilation ClassCount Mean Error StdDev Min Max
Generate AOT 0 12.39 ms 1.013 ms 0.670 ms 11.86 ms 14.13 ms
Generate AOT 1 25.57 ms 2.945 ms 1.948 ms 24.27 ms 30.93 ms
Generate AOT 10 24.73 ms 0.847 ms 0.560 ms 24.02 ms 25.58 ms
Generate AOT 25 33.86 ms 0.953 ms 0.630 ms 33.21 ms 35.51 ms
Generate AOT 50 42.83 ms 0.861 ms 0.570 ms 42.09 ms 43.80 ms
Generate AOT 100 75.79 ms 1.170 ms 0.774 ms 74.92 ms 76.93 ms
Generate AOT 200 63.03 ms 0.472 ms 0.312 ms 62.75 ms 63.72 ms
Generate JIT 0 34.56 ms 0.658 ms 0.435 ms 33.77 ms 35.30 ms
Generate JIT 1 735.06 ms 12.793 ms 8.462 ms 723.41 ms 745.21 ms
Generate JIT 10 734.02 ms 7.795 ms 5.156 ms 724.07 ms 742.34 ms
Generate JIT 25 769.62 ms 13.369 ms 8.842 ms 759.57 ms 783.65 ms
Generate JIT 50 798.38 ms 24.036 ms 15.898 ms 787.90 ms 841.86 ms
Generate JIT 100 873.71 ms 7.925 ms 5.242 ms 863.88 ms 882.27 ms
Generate JIT 200 841.58 ms 10.053 ms 6.649 ms 831.90 ms 854.20 ms

Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
…er, revert client gitignore

Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
Copilot AI changed the title Support comments on exported constructors Support comments on exported constructors Feb 28, 2026
…s has settable property

Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
Copilot AI and others added 2 commits March 1, 2026 00:06
…mment is present

Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
Co-authored-by: ArcadeMode <5969155+ArcadeMode@users.noreply.github.com>
Copilot AI and others added 2 commits March 1, 2026 00:26
@ArcadeMode ArcadeMode added this to the v1.4.0 milestone Mar 1, 2026
@ArcadeMode ArcadeMode merged commit 4654f2e into master Mar 1, 2026
13 checks passed
@ArcadeMode ArcadeMode deleted the copilot/add-commentinfo-to-constructorinfo branch March 1, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants