This repository was archived by the owner on Jul 19, 2024. It is now read-only.
Force write proto file on upload of file with different content #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
looking nice! thanks!! |
Contributor
|
really good find&fix; appreciate it ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue where the proto files in the temp directory were not being updated because they already existed. I somehow managed to get an invalid proto file in there, and then could not re-upload it because of the existsSync check.
To remedy this, I made the update modal force an update of the temp proto files when the proto file list is updated.
I also ran into an issue where the upload modal was not correctly resolving dependency proto files while validating the validity of the proto file. I added the required include dirs to fix that too.