This repository was archived by the owner on Jul 19, 2024. It is now read-only.
Fix eslint errors and re-enable it as part of the PR checks #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
aw thanks! appreciate this! |
Contributor
|
aw I really need to turn on my prettier; wasn't aware I was missing so many semicolons |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks scary but really all I did was disable some eslint rules, reduce some others to warning, and then auto-fixed all of the remaining errors and warnings.
Linting is not useful when you have linting errors all over the place and no attempt to follow it, so this Is an attempt to get this back in line.
Also added the linting step back to the workflow checks run as part of a pull request.