chore: add missing stylesheet link and correct navigation list struct… #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArchILLtect
added
the
area:web
ArchILLtect
added
project:mvp
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves HTML semantics and centralizes global styling by adding the layout.css stylesheet to the shared head-meta.jsp file and fixing a navigation markup issue where a link was not properly wrapped in a list item element.
- Adds
layout.csstohead-meta.jspfor centralized global styling across all pages - Fixes HTML structure in navigation by wrapping the "Challenges" link in a proper
<li>element with correct styling class
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/webapp/WEB-INF/jsp/head-meta.jsp | Adds global layout.css stylesheet link to ensure consistent layout across all pages |
| src/main/webapp/WEB-INF/jsp/header.jsp | Wraps "Challenges" navigation link in <li> element to match the structure of other navigation items |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
|
|
||
| <!-- Global Stylesheets-- always needed --> |
There was a problem hiding this comment.
The HTML comment is missing a space after the double hyphens. HTML comments should have a space after the opening -- and before the closing -- for proper formatting. The comment should read <!-- Global Stylesheets -- always needed -->.
Suggested change
| <!-- Global Stylesheets-- always needed --> | |
| <!-- Global Stylesheets -- always needed --> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the global styling and navigation structure of the web application. The main changes are the inclusion of a global stylesheet for consistent layout and the correction of HTML structure in the navigation menu.
Styling improvements:
layout.cssinhead-meta.jspto ensure consistent layout across all pages.Navigation markup fixes:
lielement with thecf-nav-itemclass inheader.jspto improve HTML semantics and styling consistency.