Conversation
* Updated SmartComments.vue to handle new actions and manage currentThread state. * Improved CommentActions component with new action icons and event emissions. * Enhanced styling for comment actions in panel.less. * Added visually hidden class for accessibility in smartcomments.less. * Updated Hooks.php to ensure proper module styles are loaded.
…ling in Comment and ReplyForm components, improved comments filtering in CommentTimeline, and integrated highlight removal for completed/deleted comments in commentsStore. Updated event emissions for better state management.
…aScriptLoader.php files, updated extension.json to reflect new resource paths, and improved documentation formatting in English and Dutch. Added new utility functions for event handling in frontend components.
… components to utilize Vue, enhancing UI, and adding new message translations. Introduced new composables for message handling and improved comment functionalities, including enabling replies to own comments and skipping frontend loading when comment mode is disabled.
…ns in English and Dutch. Enhanced SmartComments.vue to include tooltip functionality for annotations and improved selection validation to handle HTML content. Refactored selection handling in various components for better error messaging and user feedback.
…elated components for link prevention functionality. Removed convertSICtoSQL maintenance script and updated extension.json to include new composable. Updated documentation to reflect changes in comment editing capabilities.
…eply functionality and improve state management in the component.
… utilize getMediaWikiContentRoot consistently. Consolidate selection validation codes into SELECTION_VALIDATION for improved clarity and maintainability. Update related components to reflect these changes.
…ion.json and implementing button open text functionality in SmartComments.vue. Updated CSS properties for improved UI interaction and modified ReplyForm.vue to manage textarea state more effectively.
…by removing unnecessary display property. Improve link prevention logic in useLinkPrevention.js to allow clicks on dynamic block elements. Refactor useScreenshot.js to remove highlight classes from cloned elements before screenshotting. Adjust selection handling in useSelection.js to skip validation for dynamic blocks and check for existing comments.
… improved UI. Update useScreenshot.js to remove dynamic block classes before screenshotting. Enhance useSelection.js to capture screenshot selection area accurately with updated position calculations.
…age handling for improved user feedback.
…roved layout and user experience
…tion option in extension.json. Update link prevention logic in useLinkPrevention.js to utilize new selection handling from useSelectionEvents.js, allowing for text selection on link clicks when enabled. Refactor useSelection.js to remove unused imports and ensure cleaner code structure.
…oved code organization and maintainability. Update highlight management functions and enhance Dutch translations for tooltip text.
… UI updates. Clear existing highlights before reloading comments, and update comment text rendering to ensure proper HTML structure. Refactor event handling for comment creation to trigger highlight reloads. Remove unnecessary page refresh after comment addition for a smoother user experience.
…y pattern for improved maintainability and code organization. Consolidate selection handling into a unified interface, removing redundant composables and enhancing error handling. Update extension.json to include new selection and highlight utilities, while ensuring compatibility with existing functionality. Clean up unused files and streamline selection processes for better performance.
YvarRavy
reviewed
Jun 24, 2025
Contributor
|
on a fresh page you add one comment at the bottom of the page and one on the top. when you click the item that placed at the top of the content and you hover over the arrow it says "previous comment" which logical makes sense but since its the first comment on the page it's a bit misleading |
Contributor
|
when switching through comments, it doesn't move the side panel which is good behaviour but make add a spinner or something that gives the user feedback, if the description is similair it hard to destinct between the comments. and maybe if the comment is broken make the background red instead of yellow |
Contributor
the error message doesn't get translated to the correct language
|
robinwiel
reviewed
Jun 24, 2025
…location based on the location of the button
- Improved CommentTimeline by enlarging the icons - Allow users to place comments on the special page - Changed comment statusses to i18n messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes overview: