Add deno and update yt-dlp#1710
Closed
davidwilemski wants to merge 1 commit intoArchiveBox:stablefrom
Closed
Conversation
yt-dlp now requires a js runtime and suggests deno >=2.0 yt-dlp/yt-dlp#15012 In addition to updating the yt-dlp package there is now also a recommended external javascript blob that needs to be installed. See the [yt-dlp wiki] for install options. Here, I've added the [default] dependency group which will also install yt-dlp-ejs containing that blob. [yt-dlp wiki]: https://github.com/yt-dlp/yt-dlp/wiki/EJS
Member
|
We should make sure to use a single JS env for both single-file-cli and yt-dlp, otherwise archivebox will install 2 redundant JS runtimes. |
Member
|
I fixed this in dev, archivebox now handles npm stuff and passes NODE_BINARY to the yt-dlp plugin, which uses the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yt-dlp now requires a js runtime and suggests deno >=2.0 yt-dlp/yt-dlp#15012
In addition to updating the yt-dlp package there is now also a recommended external javascript blob that needs to be installed. See the yt-dlp wiki for install options. Here, I've added the
[default]dependency group which will also install yt-dlp-ejs containing that blob.This ensures yt-dlp continues to work. I was seeing some intermittent issues with the media extractor before this. I've tested this branch by building a docker image and running it against my archivebox install and confirming that some URLs now archive media properly.
I don't know how often the
yt-dlp-ejspackage will end up needing to be updated which may or may not be an argument in favor of eventually having an option to use the option to run the external js from npm but for now this sticks with baking an immutable docker image.I also wasn't familiar with pdm but to update the pdm lock file I just ran
pdm lockwhich seems to have worked but also updated quite a few other dependencies in that lockfile.Related issues
Changes these areas