Conversation
|
I am a beginner and would like to work on this issue. Can i take it up and be guided along? |
Member
Author
|
Yeah, go for it @ShubhGupta2125 ! The next steps are to figure out how to make chromium-browser ignore SSL errors using a command line flag or some other setting. |
Member
Author
|
I implemented this a little while ago, but thanks for your help @ShubhGupta2125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the modern age of HTTPS everywhere, it's becoming increasingly common for sites to set up SSL badly or forget to renew their certificates (especially older 90's era sites), rendering the sites inaccessible.
When browsing I always want to be alerted of bad certs, but when archiving 90% I want it to attempt archiving cites with bad certs anyway in case the content is important. After all, archiving a certificate error page is useless 100% of the time, so instead of throwing out hands up and skipping the site it's nice to at least attempt getting a snapshot.
TODO:
fetch_wgetcli option to skip cert checkfetch_pdfcli option to skip cert checkfetch_screenshotcli option to skip cert checkLast two steps just require doing some research on the chrome headless command line interface to find the right flags.
More Info:
- https://bugs.chromium.org/p/chromium/issues/detail?id=721739
- headless
--ignore-certificate-errors- https://groups.google.com/a/chromium.org/forum/#!topic/headless-dev/eiudRsYdc3A