Add --script mode to run command for inline metadata scripts by pirate · Pull Request #21 · ArchiveBox/abxpkg

pirate · 2026-04-10T07:32:48Z

Summary

This PR adds a new --script mode to the abx-pkg run command that enables executing scripts with inline /// script metadata blocks. The feature automatically parses script metadata, resolves declared dependencies, and executes the script with a PATH that includes all resolved binaries.

Key Changes

New parse_script_metadata() function: Extracts TOML-formatted metadata from /// script blocks in script files. Supports multiple comment styles (#, //, --, ;, etc.) and handles multi-line TOML structures with proper indentation preservation.
--script flag for run command: When enabled, treats the binary name as an interpreter and the first argument as a script file path. Parses the script's metadata, resolves all declared dependencies, and executes the script with an augmented PATH.
Metadata-driven dependency resolution: Scripts can declare dependencies as strings or objects with additional options (custom binproviders, min_version). The resolver collects PATH entries from all successfully resolved binaries.
Tool configuration support: Scripts can include [tool.abx-pkg] sections in metadata to set defaults for postinstall_scripts, min_release_age, and min_version. CLI flags take precedence over metadata settings.
Comprehensive test coverage: Added 16 unit tests for metadata parsing (various comment styles, edge cases, TOML structures) and 7 integration tests for the full run --script workflow (argument passing, error handling, exit code propagation, CLI override behavior).

Implementation Details

Metadata parsing scans only the first 50 lines by default to avoid performance issues with large files
Metadata blocks must be properly closed with a /// marker; unclosed blocks return None
The script path is resolved to absolute before execution to ensure correct working directory behavior
Exit codes from executed scripts propagate through abx-pkg unchanged
Dry-run mode (--dry-run) resolves dependencies but skips actual script execution

https://claude.ai/code/session_0125eDj24UMFUhMUN8x2zmHB

Summary by cubic

Adds --script mode to abx-pkg run to execute scripts with inline /// script metadata, auto-resolve dependencies, and set PATH/ENV for the chosen interpreter. Also unifies installer discovery and runtime ENV across providers, and makes version reporting resilient to missing installers.

New Features
- run --script INTERPRETER SCRIPT_PATH [ARGS...] (shebang: #!/usr/bin/env -S abx-pkg run --script node). Implies --install; --dry-run only resolves.
- Comment‑agnostic parser scans the first 50 lines for a closed /// script TOML block.
- Builds PATH and ENV from providers; [tool.abx-pkg] values export to env vars (CLI flags still override). README adds examples.
- playwright/puppeteer: global/managed/hermetic npm resolution.
Refactors
- Unified installer discovery via INSTALLER_BINARY(), guarding abspath lookups and avoiding detect_euid recursion; version report skips missing installer binaries.
- Providers expose ENV; apply_env() merges vars. Sets common vars like VIRTUAL_ENV, PYTHONPATH, NODE_PATH, HOMEBREW_PREFIX, GEM_HOME, GOPATH, DENO_DIR, PLAYWRIGHT_BROWSERS_PATH, PUPPETEER_CACHE_DIR.
- Default install roots come from abx_pkg_install_root_default() which reads ABX_PKG_LIB_DIR at runtime; removed MANAGED_PROVIDER_ROOTS.
- Subprocess output formatter accepts bytes for robust logging. CI: per‑ref concurrency with cancel‑in‑progress and 20‑minute timeouts in tests, release, and deploy-pages.

^{Written for commit 18eeb66. Summary will update on new commits.}

cubic-dev-ai · 2026-04-10T08:36:09Z

You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment @cubic-dev-ai review.

pirate · 2026-04-10T10:05:24Z

@cubic-dev-ai review

cubic-dev-ai · 2026-04-10T10:05:40Z

@cubic-dev-ai review

@pirate I have started the AI code review. It will take a few minutes to complete.

pirate · 2026-04-10T22:28:13Z

+            try:
+                return self.INSTALLER_BINARY(no_cache=no_cache).loaded_abspath
+            except Exception:
+                return None


shouldnt this be in the base method not the override?

pirate · 2026-04-10T22:30:05Z

    def default_abspath_handler(
        self,
        bin_name: BinName | HostBinPath,
+        no_cache: bool = False,
        **context,
    ) -> HostBinPath | None:
        if str(bin_name) == self.INSTALLER_BIN:
-            return self.INSTALLER_BIN_ABSPATH
+            try:
+                return self.INSTALLER_BINARY(no_cache=no_cache).loaded_abspath
+            except Exception:
+                return None
        bin_dir = self.bin_dir
        assert bin_dir is not None
        link_path = bin_dir / str(bin_name)


cant this just be on the base? then we dont need this same override everywhere.

Checking bin_dir for the bin_name seems like the most common pattern

- parse_script_metadata(): comment-syntax-agnostic /// script parser - --script flag on run command with automatic dep resolution - BinProvider.ENV computed property + apply_env() for runtime env vars - ENV overrides on all 14 providers - [tool.abx-pkg] values passed through as env vars verbatim - Removed MANAGED_PROVIDER_ROOTS — providers resolve install_root from ABX_PKG_LIB_DIR via default_factory - abx_pkg_install_root_default reads env vars fresh (not cached) - Playwright/puppeteer: 3-mode npm resolution (global/managed/hermetic) https://claude.ai/code/session_0125eDj24UMFUhMUN8x2zmHB

devin-ai-integration

Devin Review found 2 new potential issues.

View 38 additional findings in Devin Review.

devin-ai-integration · 2026-04-12T06:45:36Z

🔴 Yarn Berry install drops --force flag when postinstall_scripts=True and no_cache=True

In default_install_handler, the condition for adding --force was changed from if no_cache and "--force" not in cmd to if no_cache and not is_berry and "--force" not in cmd. For Yarn Berry with postinstall_scripts=True, the code never enters the Berry-specific if is_berry and not postinstall_scripts: branch (which is the only other place --force is added for Berry). This means --no-cache no longer forces a fresh install for Yarn Berry when postinstall scripts are enabled, silently serving stale cached packages.

Old vs new behavior trace

Old code path (Berry, postinstall_scripts=True, no_cache=True):

cmd = ["add", ...]

no_cache=True → --force added

is_berry and not postinstall_scripts = False → skip

Result: --force present ✅

New code path:

cmd = ["add", ...]

no_cache and not is_berry = False → --force NOT added

is_berry and not postinstall_scripts = False → skip

Result: --force missing ❌

(Refers to line 296)

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-04-12T06:45:37Z

            if not postinstall_scripts:
                cmd = [
                    "up",
                    *self.yarn_install_args,
-                    *(
-                        ["--force"]
-                        if no_cache and "--force" not in self.yarn_install_args
-                        else []
-                    ),
                    "--mode",
                    "skip-build",
                    *install_args,


🔴 Yarn Berry update handler completely drops --force for no_cache=True

The default_update_handler for Yarn Berry entirely removes the --force flag logic. In the old code, --force was added for Berry when no_cache=True in both the postinstall_scripts=True and postinstall_scripts=False branches. The new code removes the --force insertion for Berry in both branches, so --no-cache on update has no effect for Berry Yarn. The not postinstall_scripts branch also lost its --force injection (abx_pkg/binprovider_yarn.py:383-398).

(Refers to lines 376-383)

Prompt for agents

In binprovider_yarn.py default_update_handler, the Berry branch (is_berry=True) no longer adds --force when no_cache=True. The old code had: if is_berry: cmd = ["up", *self.yarn_install_args, *install_args] if no_cache and "--force" not in cmd: cmd.insert(1, "--force") The new code removes the --force insertion entirely for Berry. Need to restore --force for no_cache=True in the Berry update path. This affects both the postinstall_scripts=True path (line 376, where cmd is built but --force never added) and the postinstall_scripts=False path (lines 378-383, where the cmd is rebuilt without --force).

Was this helpful? React with 👍 or 👎 to provide feedback.