lots of small test improvements and speedups#23
Conversation
There was a problem hiding this comment.
🟡 Dry-run logs "DRY RUN" for version probes that actually execute
The new is_version_probe bypass at abx_pkg/binprovider.py:1041 lets version-probe commands (--version, -version, -v) run even during dry_run. However, the logging block at abx_pkg/binprovider.py:997-1002 still prints "DRY RUN ({class}): {cmd}" for these commands because it only checks self.dry_run, not is_version_probe. Users reading logs will see a command labeled "DRY RUN" that was actually executed, which is misleading.
Code flow showing the inconsistency
The log at line 997-1002 fires when self.dry_run is true and no exec_log_prefix is set (which is the case for version probes during load() / INSTALLER_BINARY()). Then at line 1041, the version probe bypasses the dry_run short-circuit and actually runs. The log said "DRY RUN" but the subprocess ran for real.
(Refers to lines 997-1002)
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary by cubic
Speeds up the test suite and makes provider behavior more predictable. CI now installs Yarn classic and a
yarn-berryalias, fixes PATH setup, and verifies both versions.Test Suite
yarn-berry; addno_cachetests that replace broken cached packages when scripts are re‑enabled; verify classic fallback warnings.supports_*asserts. Slim CLI tests by stubbingrun_binary_command.Providers and CI
YarnProvider: on Berry,no_cacherunsyarn cache clean --all; prepend PATH correctly; simplifyadd/upcommand building with--mode skip-build.PlaywrightProvider: respectABX_PKG_LIB_DIRand share the npm root; better CLI bootstrap/cache detection; ensure dirs exist; seed installer cache after npm install.GoGetProvider: preserve existing PATH when merging (remove dead branch) and correctly resolve installer version viago versionduring dry runs.BinProvider: realpwd.struct_passwdfallback; allow--versionprobes even indry_run; construct dry-run binaries viamodel_construct; hideis_validin repr.yarn@1.22.22) and Yarn Berry via@yarnpkg/cli-dist@4.13.0asyarn-berry; add alias to PATH; verifyyarnis 1.x andyarn-berryis 4.x; pinpnpm@10.19.0; drop corepack.$ABX_PKG_LIB_DIR/*and clarify Yarn workspace behavior.Written for commit 5cf87ee. Summary will update on new commits.