Correct sign in solar_geom azimuth #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you Marco for the PR! |
Owner
|
Wow what a catch! I see the same behavior. I cannot believe such typo was not noticed earlier, quite a shame. |
Owner
|
I am packaging a new release with your PR. |
Collaborator
|
thanks for finding and solving! Just reading after back from hols.....
…On Mon, 5 May 2025 at 15:36, Simon Filhol ***@***.***> wrote:
*ArcticSnow* left a comment (ArcticSnow/TopoPyScale#117)
<#117 (comment)>
Wow what a catch! I see the same behavior. I cannot believe such typo was
not noticed earlier. Grazie mille!
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRO2BHPC2CR622BLQWFUL3245SODAVCNFSM6AAAAAB4KECHPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJRGAZTQMBWHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Dr Joel Fiddes-Caduff
WSL Institute for Snow and Avalanche Research SLF
Research Unit Snow and Permafrost
Flüelastrasse 11, CH-7260 Davos Dorf
Phone: +41 81 4170 274 | E-mail: ***@***.***
Web : http://www.slf.ch/ueber/organisation/schnee_permafrost
|
Author
|
No worries, thanks Simon for packaging the new release : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two different conventions with regards to solar azimuths in pvlib (0N, 90E, 180S, 270W) and here in TopoPyScale (0S,180N, -90W and 90E). I think the solution is that we need to change sign to the azimuth other than subtracting 180. Let me know if it also makes sense to you.
I realized the error because I had strong SW radiation on a west-facing slope in the morning and not in the afternoon:
