Libraries: Match output type and variable type #10151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the AP_HAL formatting changes asnd RC_Channel changes look good to me. These change are pretty much only affecting debug messages so I think they are safe to merge as is. |
khancyr
approved these changes
Jan 12, 2019
|
Looks like this should have been merged and wasn't. @muramura could you rebase, please? |
WickedShell
reviewed
Apr 23, 2019
| @@ -435,7 +435,7 @@ static void PrintDebug(const Proto* f) | |||
| printf("upvalues (%d) for %p:\n",n,VOID(f)); | |||
| for (i=0; i<n; i++) | |||
| { | |||
| printf("\t%d\t%s\t%d\t%d\n", | |||
| printf("\t%d\t%s\t%u\t%u\n", | |||
There was a problem hiding this comment.
Remove the change here, this is external code dependencies, and I'd rather not add conflicts.
|
@muramura this hasn't been rebased. |
|
the RC decoders in AP_HAL/utility are going to be removed and replaced with AP_RCProtocol |
khancyr
force-pushed
the
AP_Match_output_type_and_variable_type
branch
from
e68a200
to
7dec784
Compare
|
rebase, drop tabs change, address comment |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was detected with the cppcheck command that there was no output type and variable type.
I think that matching the type will increase the authenticity of the message.