-
Notifications
You must be signed in to change notification settings - Fork 17k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS: fix printf error #12946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tryingto tack on "long" to the format leads to 32-vs-64-bit pain.
Casting to unsigned is our pattern.
4bd9977
to
63b1635
Compare
why the travis-ci is not passing? |
@Huibean, looks like a server issue, I've kicked it off again and maybe it will work this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Huibean Patches look good now, but the commit message needs fixing. We require a commit-per-directory, and for that directory name to prepend the commit description.
In this case AP_HAL_ChibiOS: fix printf error
would be a reasonable commit message.
63b1635
to
09638bf
Compare
@peterbarker I got it, updated |
09638bf
to
63241bc
Compare
63241bc
to
1bc3024
Compare
already fixed |
fix spi clock debug error
../../libraries/AP_HAL_ChibiOS/SPIDevice.cpp: In static member function 'static void ChibiOS::SPIDevice::test_clock_freq()': ../../libraries/AP_HAL_ChibiOS/SPIDevice.cpp:433:61: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'uint32_t {aka long unsigned int}' [-Werror=format=] hal.console->printf("Waiting %u\n", AP_HAL::millis()); ~~~~~~~~~~~~~~~~^