AP_HAL_ChibiOS: fix printf error #12946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
previously requested changes
Dec 2, 2019
Huibean
force-pushed
the
fix-spi-clock-debug-msg
branch
3 times, most recently
from
4bd9977
to
63b1635
Compare
|
why the travis-ci is not passing? |
|
@Huibean, looks like a server issue, I've kicked it off again and maybe it will work this time. |
peterbarker
requested changes
Dec 2, 2019
There was a problem hiding this comment.
@Huibean Patches look good now, but the commit message needs fixing. We require a commit-per-directory, and for that directory name to prepend the commit description.
In this case AP_HAL_ChibiOS: fix printf error would be a reasonable commit message.
Huibean
force-pushed
the
fix-spi-clock-debug-msg
branch
from
63b1635
to
09638bf
Compare
|
@peterbarker I got it, updated |
peterbarker
reviewed
Dec 3, 2019
Huibean
force-pushed
the
fix-spi-clock-debug-msg
branch
from
09638bf
to
63241bc
Compare
Huibean
force-pushed
the
fix-spi-clock-debug-msg
branch
from
63241bc
to
1bc3024
Compare
|
already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix spi clock debug error
../../libraries/AP_HAL_ChibiOS/SPIDevice.cpp: In static member function 'static void ChibiOS::SPIDevice::test_clock_freq()': ../../libraries/AP_HAL_ChibiOS/SPIDevice.cpp:433:61: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'uint32_t {aka long unsigned int}' [-Werror=format=] hal.console->printf("Waiting %u\n", AP_HAL::millis()); ~~~~~~~~~~~~~~~~^