Copter: disable gcs failsafe by default #13098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
Dec 23, 2019
|
Merged, thanks! Happy to hear from other devs if there are any objections |
|
No objections - reasonable change - but are the failures legit or are there actual bugs with GCS failsafe? |
|
@peterbarker, txs for the feedback. So far what I've seen, they are all legitimate failures. So for example, the user has a GCS connected temporarily to change some parameters before takeoff but doesn't really intend to rely on it during the flight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables Copter's GCS failsafe by default. This change is being made in response to beta testers' reports that it has been triggering unexpectly or causing pre-arm failures (I've noticed this myself).
I think it is safe to disable the GCS failsafe by default (it was enabled by default in 3.6.x and earlier) because nobody has been relying on it because it was not actually function. It didn't do anything that the regular RC failsafe didn't already do.
FYI to @Pedals2Paddles