Revert "AP_HAL_Chibios: Change RC in to RCINT to free a DMA channel" #18703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8b7b4d6. This killed RCIN on my ZealotF427 - it does decode SBUS but RC is unreliable and "RC fail" is spewed acroos the MAVProxy console
|
@peterbarker can you get a capture of the sbus traffic with your Saleae so we can try to work out why it doesn't work? |
|
Looks like this change made it into 4.1 so presumably if we revert it in master we should also revert it in 4.1? If "yes" let's set the "Projects" to 4.1 as well so we don't lose track. |
|
it turns out the receiver was only giving a 1.8v signal, so invalid for 3.3v signalling. So this revert is not valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8b7b4d6.
The reverted commit killed RCIN on my ZealotF427 - it does decode SBUS but RC is
unreliable and "RC fail" is spewed acroos the MAVProxy console
@Hwurzburg - presumably this will cause issues with CrossFire?
My setup is a Jumper R8 receiver connected to both the Zealot's RCIN port and GPS2 (for telemetry)