Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Solo Gimbal except on CubeSolo and CubeGreen-solo #20328

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

peterbarker
Copy link
Contributor

Pixhawk1:

image

Pixhawk1-1M isn't affected because it's already excluded.

CubeSolo is still the same - well, 12 bytes off...

I'd note that this means gimbal will stop working for users with a gimbal on CubeOrange. I'm just copying the broken-ness because they'll also be missing OreoLED support....

@peterbarker peterbarker changed the title Pr/disable hal solo gimbal Disable Solo Gimbal except on CubeSolo and CubeGreen-solo Mar 18, 2022
@khancyr
Copy link
Contributor

khancyr commented Mar 18, 2022

Lgtm, there won't be a lot of solo gimbal outside solo anyway, so that is manageable

@peterbarker
Copy link
Contributor Author

peterbarker commented Mar 19, 2022

Durandal:

 Binary Name      Text [B]           Data [B]     BSS (B)       Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -----------------  -----------  ------------  ----------------------------  -------------------------
antennatracker   -808 (-0.0599%)    0 (0.0000%)  0 (0.0000%)   -808 (-0.0598%)                                  616768
blimp            -808 (-0.0626%)    0 (0.0000%)  0 (0.0000%)   -808 (-0.0626%)                                  675336
ardurover        -17848 (-1.1234%)  0 (0.0000%)  0 (0.0000%)   -17848 (-1.1221%)                                393360
arducopter-heli  -17736 (-0.9916%)  0 (0.0000%)  0 (0.0000%)   -17736 (-0.9898%)                                191940
ardusub          -17836 (-1.1373%)  0 (0.0000%)  4 (+0.0015%)  -17836 (-1.1360%)                                413800
arduplane        -17836 (-1.0136%)  0 (0.0000%)  4 (+0.0015%)  -17836 (-1.0119%)                                221232
arducopter       -17424 (-0.9801%)  0 (0.0000%)  0 (0.0000%)   -17424 (-0.9784%)                                202612

@peterbarker
Copy link
Contributor Author

Tracker and Blimp don't do Mount but they do do camera:
image

@tridge
Copy link
Contributor

tridge commented Mar 22, 2022

needs CubeOrange and fmuv3

@peterbarker
Copy link
Contributor Author

needs CubeOrange and fmuv3

Done

@peterbarker peterbarker force-pushed the pr/disable-hal-solo-gimbal branch 2 times, most recently from 1e615a3 to e206e47 Compare March 23, 2022 09:21
for users running fmuv3 on their Solo
@rmackay9 rmackay9 merged commit 29c2c40 into ArduPilot:master Mar 28, 2022
@peterbarker peterbarker deleted the pr/disable-hal-solo-gimbal branch March 30, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants