-
Notifications
You must be signed in to change notification settings - Fork 16.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Solo Gimbal except on CubeSolo and CubeGreen-solo #20328
Merged
rmackay9
merged 4 commits into
ArduPilot:master
from
peterbarker:pr/disable-hal-solo-gimbal
Mar 28, 2022
Merged
Disable Solo Gimbal except on CubeSolo and CubeGreen-solo #20328
rmackay9
merged 4 commits into
ArduPilot:master
from
peterbarker:pr/disable-hal-solo-gimbal
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amilcarlucas
approved these changes
Mar 18, 2022
Lgtm, there won't be a lot of solo gimbal outside solo anyway, so that is manageable |
khancyr
approved these changes
Mar 18, 2022
Durandal:
|
needs CubeOrange and fmuv3 |
771bb6d
to
ba2e5d2
Compare
Done |
for users who have replaced their CubeSolo with a CubeOrange
1e615a3
to
e206e47
Compare
for users running fmuv3 on their Solo
e206e47
to
2b92e42
Compare
IamPete1
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pixhawk1
:Pixhawk1-1M isn't affected because it's already excluded.
CubeSolo is still the same - well, 12 bytes off...
I'd note that this means gimbal will stop working for users with a gimbal on CubeOrange. I'm just copying the broken-ness because they'll also be missing OreoLED support....