-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor microstrain to common library #24723
Merged
tridge
merged 5 commits into
ArduPilot:master
from
Ryanf55:refactor-microstrain-to-common-library
Aug 29, 2023
Merged
Refactor microstrain to common library #24723
tridge
merged 5 commits into
ArduPilot:master
from
Ryanf55:refactor-microstrain-to-common-library
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer libraries/AP_ExternalAHRS/MicroStrain_common.{cpp,h}
Ryanf55
force-pushed
the
refactor-microstrain-to-common-library
branch
from
August 23, 2023 03:18
6f92260
to
843036d
Compare
Done! |
Ryanf55
force-pushed
the
refactor-microstrain-to-common-library
branch
from
August 27, 2023 23:22
843036d
to
196501c
Compare
* Move common parsing to MicroStrain_common * Add propogation of parsed packet type back to the driver * Rename the driver to add series-5 specifier * Unlocks adding 7-series driver with less code duplication * Add missing includes Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Ryanf55
force-pushed
the
refactor-microstrain-to-common-library
branch
from
August 28, 2023 02:26
f275aa7
to
cd79ed2
Compare
|
tridge
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors out out the common shared logic from microstrain series 5 and 7 (mainly, the parsing). This will allow creating the 7-series driver with far less code duplication. Logic was not impacted. On SITL, I just renamed the class to make it clear it's a simulator for the 5-series. The 7-series uses some different packets, and also has two GPS instances.
https://ardupilot.org/copter/docs/parameters.html#gps-type
https://ardupilot.org/copter/docs/common-external-ahrs.html
https://github.com/ardupilot/ardupilot/blob/master/libraries/SITL/SIM_MicroStrain.h#L3
Test:
autotest.py build.Plane test.Plane.MicroStrainEAHRS --debug
sim_vehicle.py -v Plane -DG --console --map -A --uartE=sim:MicroStrain
sim_vehicle.py -v Plane -DG --console -A --uartE=sim:MicroStrain -B AP_ExternalAHRS_MicroStrain5.cpp:98