-
Notifications
You must be signed in to change notification settings - Fork 17.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_IOMCU: allow up to 16 channels of servo data to be sent to the iomcu #26898
Conversation
yay! Thanks so much for this! |
@rmackay9 will test |
we need to work out where the duplicates on chan13 came from, maybe gdb on IOMCU looking in SBUS out function to see where it got the value from. Concern is this is a crash bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me and I've tested this resolves the issue, thanks!
After this change there is just a single use of IOMCU_MAX_CHANNELS on line 1152 of iofirmware.cpp. I'm just guessing but should that line also be changed? |
No, that one is correct |
Fixes #26851