Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MFT-SEMA100 Board #27588

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Added MFT-SEMA100 Board #27588

merged 2 commits into from
Aug 2, 2024

Conversation

EternAlmox
Copy link
Contributor

@EternAlmox EternAlmox commented Jul 18, 2024

This PR adds support for a new autopilot called the MFT-SEMA100

@rmackay9
Copy link
Contributor

Hi @EternAlmox,

Thanks for the PR!

A couple of small administrative issues:

  • could you rebase on master so that the "merge" commits disappear?
  • we always like to prefix our commits with the folder name (or subsystem name) in order to make backporting easier. I allows us to quickly look at each commit and see which area of the code is affected. Could you add a prefix to each of the commits?
    • rename "Add files via upload" to something like, "AP_HAL_ChibiOS: add support for MFT-SEMA100"
  • I think it might be possible to "squash" some of the commits togethers. For example, the two commits called "Add files via upload" and the "Create README.md" could be merged together.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Jul 22, 2024
@Hwurzburg Hwurzburg self-requested a review July 22, 2024 23:10
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started to review this and had some issues in the defs...so putting off README review until these get resolve:
1. Biggest is that UART ORDER and configured UARTS do not match....cant tell what is really desired
2. The USB config is unfamiliar to me, and apparently CAN2 cant be used if normal HS USB is enabled? needs review by Tridge
3. The bootloader does not setup SD card which I think is desireable now
4. I would expect BiDir could be setup on some output groups
5. Dont understand why SERIAL4 baud is setup...should not be needed for GPS
6. Need to know if any CAN periphs are bundled with autopilot to decide on enabling CAN1 by default

@EternAlmox
Copy link
Contributor Author

Couldnt managed to add BiDir to any of the outputs. I might need professional help but couldnt find any yet.

There isnt any CAN periphs bundled with autopilot so no need to be enabled by default

@Hwurzburg
Copy link
Collaborator

we dont put .apj in bootloaders dir....just .bin and also .hex...but .bin is the required one

@Hwurzburg
Copy link
Collaborator

Removed .hex not .apj

@tridge
Copy link
Contributor

tridge commented Aug 1, 2024

rebased and squashed commits

@tridge tridge merged commit 8fd9946 into ArduPilot:master Aug 2, 2024
47 checks passed
@rmackay9
Copy link
Contributor

I tried to include this in 4.5.6-beta1 but was unable to due to a merge conflict. If someone is keen on including this in 4.5 then a backport PR would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.5.6-beta1
Development

Successfully merging this pull request may close these issues.

None yet

5 participants