-
Notifications
You must be signed in to change notification settings - Fork 17.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions: fix tests that don't like repos not called "ardupilot" #27612
Actions: fix tests that don't like repos not called "ardupilot" #27612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
truely a git annoyance ...
for the question why it is faster on ardupilot, I think we got an upgraded plan as FOSS project an have better machine for CI. |
We can merge without waiting environement tests to pass as they are failing due to some setuptools issues, so not related |
My repo is one of these actually |
@khancyr can you do a PR against this PR that fixes the tests so env install works again? |
The Jammy environment install was fixed in #27609 Focal is still outstanding |
86bf77a
to
bcf7462
Compare
bcf7462
to
3024cf4
Compare
A few of the git safe directory calls assume the repo is called
ardupilot
, if your fork happens not to be called that then CI fails. GitHub provides us with a environmental variable to get the correct directory which we already use in most places. The tricky one is cygwin which uses the repo name, but on a different path, so in that case I have to some messing about to extract the repo name fromGITHUB_REPOSITORY
andGITHUB_REPOSITORY_OWNER
(see https://tom-gallacher.co.uk/articles/how-to-github-actions-repo-name/)This also ups the timeout for the environment install scripts from 45 mins to 60 mins. These seem to run a bit slower outside of the main repo, I'm not sure why.