Actions: fix tests that don't like repos not called "ardupilot" #27612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancyr
approved these changes
Jul 22, 2024
|
for the question why it is faster on ardupilot, I think we got an upgraded plan as FOSS project an have better machine for CI. |
|
We can merge without waiting environement tests to pass as they are failing due to some setuptools issues, so not related |
|
My repo is one of these actually |
tridge
approved these changes
Jul 23, 2024
|
@khancyr can you do a PR against this PR that fixes the tests so env install works again? |
|
The Jammy environment install was fixed in #27609 Focal is still outstanding |
IamPete1
force-pushed
the
actions_for_none_ardupilot
branch
from
86bf77a
to
bcf7462
Compare
peterbarker
force-pushed
the
actions_for_none_ardupilot
branch
from
bcf7462
to
3024cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the git safe directory calls assume the repo is called
ardupilot, if your fork happens not to be called that then CI fails. GitHub provides us with a environmental variable to get the correct directory which we already use in most places. The tricky one is cygwin which uses the repo name, but on a different path, so in that case I have to some messing about to extract the repo name fromGITHUB_REPOSITORYandGITHUB_REPOSITORY_OWNER(see https://tom-gallacher.co.uk/articles/how-to-github-actions-repo-name/)This also ups the timeout for the environment install scripts from 45 mins to 60 mins. These seem to run a bit slower outside of the main repo, I'm not sure why.