Skip to content

Add Lego Power Functions tests#336

Merged
z3t0 merged 12 commits intoArduino-IRremote:masterfrom
philipphenkel:lego_pf_tests
Jul 27, 2016
Merged

Add Lego Power Functions tests#336
z3t0 merged 12 commits intoArduino-IRremote:masterfrom
philipphenkel:lego_pf_tests

Conversation

@philipphenkel
Copy link
Copy Markdown
Contributor

I moved the BitStreamEncoder code to a separate header file in order to allow basic unit testing with a dedicated test sketch.

@z3t0
Copy link
Copy Markdown
Collaborator

z3t0 commented Jul 12, 2016

This will be put on hold while we figure things out at #333

@philipphenkel
Copy link
Copy Markdown
Contributor Author

BitStreamEncoder is actually a protocol implementation that plugs into a simple, straight forward IRsend send function. I'm sure whatever the outcome of #333 is, the Lego Power Functions part can be easily adapted to match the new structure. Let me know when you are ready.

    bitStreamEncoder.reset(data, repeat);
    do {
      mark(bitStreamEncoder.getMarkDuration());
      space(bitStreamEncoder.getPauseDuration());
    } while (bitStreamEncoder.next());

@z3t0
Copy link
Copy Markdown
Collaborator

z3t0 commented Jul 24, 2016

In that case, I might as well implement this as it may be a while until we have #333 sorted out, if possible please check and update the PR against master as I just merged another PR so that would have offset your commits

@philipphenkel
Copy link
Copy Markdown
Contributor Author

@z3t0 I updated against master. The PR is ready to be merged.

@z3t0
Copy link
Copy Markdown
Collaborator

z3t0 commented Jul 27, 2016

Looks good, just one more thing, please add your changes to the changelog and just bump the version

@philipphenkel
Copy link
Copy Markdown
Contributor Author

@z3t0 Changelog and versions are up-to-date now

@z3t0 z3t0 merged commit bb0323b into Arduino-IRremote:master Jul 27, 2016
@z3t0
Copy link
Copy Markdown
Collaborator

z3t0 commented Jul 27, 2016

Thank you for your efforts! and I apologize for not helping out with the merge.

Theaninova pushed a commit to Theaninova/Arduino-IRremote that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants