Conversation
…nd diffstar fit files
aphearin
approved these changes
Sep 26, 2025
Contributor
aphearin
left a comment
aphearin
left a comment
There was a problem hiding this comment.
Nice work on this PR - time for a new release! Woohoo!!
Contributor
There was a problem hiding this comment.
Wow, our kernels are so much simpler now!
| default=dfh.SSFRH_FLOOR, | ||
| ) | ||
| parser.add_argument("-test", help="Short test run?", type=bool, default=False) | ||
| parser.add_argument("-nchunks", help="Number of chunks", type=int, default=NCHUNKS) |
Contributor
There was a problem hiding this comment.
I think maybe nchunks might be an accidental carryover from the HACC simulations? I could be wrong, but I don't see where this feature is used by these fitters.
Contributor
There was a problem hiding this comment.
Although since this is in a script, we may want to not change this for now since there wouldn't be unit tests that would catch an accidentally introduced error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings a new version of the Diffstar model.
The new Diffstar model uses a reformulation in which the star formation rate is defined as an efficiency (measured in units of inverse time) relative to the cumulative accreted gas mass. It can be summarized by the following set of equations: