Skip to content

Conversation

@yfrigui2
Copy link
Contributor

@yfrigui2 yfrigui2 commented Nov 24, 2025

Adjust styling of evaluator config dialog to handle overflows


Note

Add truncation and overflow handling to evaluator dialog title and dataset select button, plus spacing tweaks in dialog header.

  • Evaluator Config Dialog (EvaluatorConfigDialog.tsx):
    • Wrap title sections with overflow: hidden and use Truncate for evaluator.name and dataset.name.
    • Adjust title layout with Flex props (maxWidth, flexBasis, minWidth) to prevent overflow.
  • Dataset Picker (DatasetSelectWithSplits.tsx):
    • Add overflow: hidden to button content and use Truncate for dataset and split text.
    • Refactor split label rendering within Text using Truncate and spacing entities.
  • Dialog Header (Dialog.tsx):
    • Add gap="size-200" to header Flex for consistent spacing.

Written by Cursor Bugbot for commit cb1b64e. This will update automatically on new commits. Configure here.

@yfrigui2 yfrigui2 requested a review from a team as a code owner November 24, 2025 15:22
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Nov 24, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 24, 2025
@github-project-automation github-project-automation bot moved this from 📘 Todo to 👍 Approved in phoenix Nov 24, 2025
@yfrigui2 yfrigui2 merged commit 905764c into version-13 Nov 24, 2025
21 of 22 checks passed
@yfrigui2 yfrigui2 deleted the yasmine/fix-evaluator-config-dialog-layout branch November 24, 2025 15:40
@github-project-automation github-project-automation bot moved this from 👍 Approved to ✅ Done in phoenix Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants