Skip to content

fix: fix evaluator config dialog layout #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2025
Merged

fix: fix evaluator config dialog layout #10366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8389fec
fix evaluator config dialog header overflow
yfrigui2 Nov 21, 2025
a223976
fix dataset select overflow
yfrigui2 Nov 21, 2025
9d4d632
styling
yfrigui2 Nov 24, 2025
cb1b64e
dataset select styling
yfrigui2 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions app/src/components/dataset/DatasetSelectWithSplits.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,20 +154,32 @@ export function DatasetSelectWithSplits(props: DatasetSelectWithSplitsProps) {
size={props.size ?? "S"}
isDisabled={props.isDisabled}
>
<Flex alignItems="center" width="100%">
<Flex
alignItems="center"
width="100%"
css={css`
overflow: hidden;
`}
>
{selectedDataset ? (
<>
<Text>{selectedDataset.name}</Text>
{selectedSplits.length > 0 ? (
<Text color="text-300">
&nbsp;/{" "}
{selectedSplits.length === 1
? selectedSplits[0].name
: `${selectedSplits.length} splits`}
</Text>
) : (
<Text color="text-300">&nbsp;/ All Examples</Text>
)}
<Text>
<Truncate maxWidth="10rem">{selectedDataset.name}</Truncate>
</Text>
<Text color="text-300" minWidth={0}>
<Truncate maxWidth="100%">
{selectedSplits.length > 0 ? (
<>
&nbsp;/&nbsp;
{selectedSplits.length === 1
? selectedSplits[0].name
: `${selectedSplits.length} splits`}
</>
) : (
<>&nbsp;/ All Examples</>
)}
</Truncate>
</Text>
</>
) : (
<Text color="text-300">
Expand Down
7 changes: 6 additions & 1 deletion app/src/components/dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ export const DialogHeader = ({ children, ...props }: DialogHeaderProps) => {
css={dialogHeaderCSS}
className={classNames(props.className, "ac-DialogHeader")}
>
<Flex width="100%" justifyContent="space-between" alignItems="center">
<Flex
width="100%"
justifyContent="space-between"
alignItems="center"
gap="size-200"
>
{children}
</Flex>
</div>
Expand Down
34 changes: 28 additions & 6 deletions app/src/pages/dataset/evaluators/EvaluatorConfigDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { EvaluatorExampleDataset } from "@phoenix/components/evaluators/Evaluato
import { EvaluatorFormValues } from "@phoenix/components/evaluators/EvaluatorForm";
import { EvaluatorInputMapping } from "@phoenix/components/evaluators/EvaluatorInputMapping";
import { PromptChatMessages } from "@phoenix/components/prompt/PromptChatMessagesCard";
import { Truncate } from "@phoenix/components/utility/Truncate";
import { useNotifyError, useNotifySuccess } from "@phoenix/contexts";
import { EvaluatorConfigDialog_dataset$key } from "@phoenix/pages/dataset/evaluators/__generated__/EvaluatorConfigDialog_dataset.graphql";
import {
Expand Down Expand Up @@ -241,17 +242,38 @@ function EvaluatorConfigDialogContent({
return (
<>
<DialogHeader>
<DialogTitle>
<Flex direction="row" alignItems="center" gap="size-50">
<DialogTitle
css={css`
overflow: hidden;
`}
>
<Flex
direction="row"
alignItems="center"
gap="size-50"
maxWidth="100%"
>
Add
<Flex direction="row" alignItems="center" gap="size-25">
<Flex
direction="row"
alignItems="center"
gap="size-25"
flexBasis="100%"
minWidth={0}
>
<Icon svg={<Icons.Scale />} />
{evaluator.name}
<Truncate maxWidth="100%">{evaluator.name}</Truncate>
</Flex>
to
<Flex direction="row" alignItems="center" gap="size-25">
<Flex
direction="row"
alignItems="center"
gap="size-25"
flexBasis="100%"
minWidth={0}
>
<Icon svg={<Icons.DatabaseOutline />} />
{dataset.name}
<Truncate maxWidth="100%">{dataset.name}</Truncate>
</Flex>
</Flex>
</DialogTitle>
Expand Down
Loading