fix: decode project keys with longest-match backtracking#92
Merged
Conversation
When two sibling directories share a prefix (e.g. `diary/` and `diary-app/`), the greedy shortest-match decoder picked the shorter name and then failed to resolve the remainder, so the homepage Resume Conversation list showed those workingDirs as $HOME and resume targeted the wrong folder. Switch to recursive backtracking with longest-join-first at each segment boundary; require every step to be a real directory. Keep the greedy path as a fallback for deleted dirs.
Owner
|
Thanks for the thoughtful fix! Good catch on the sibling-prefix collision — the longest-match backtracking with the greedy fallback for deleted dirs is exactly the right shape. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When two sibling directories share a prefix (e.g.
diary/anddiary-app/), the greedy shortest-match decoder indecodeProjectKey()picks the shorter name and then fails to resolve the remainder. As a result:workingDirs as$HOMEFix
Switch to recursive backtracking with longest-join-first at each segment boundary; require every step to be a real directory on disk. Keep the greedy path as a fallback for deleted directories (so history of deleted projects still resolves).
Test plan
tsc --noEmitpassesnpm run lintpassesnpm run format:checkpasses~/foo/diary/and~/foo/diary-app/both resolve correctly in the Resume Conversation list and Resume button targets the right folder.