feat: View all in folder modal for Resume Conversation#94
Merged
Conversation
Drill into a single project's complete history when the homepage's
3-per-project dedup hides older conversations.
- Backend: /api/history/sessions accepts projectKey/offset/limit;
single-folder mode bypasses the 50-cap and returns { sessions, total }.
projectKey is validated against ^[A-Za-z0-9_-]+$ to prevent traversal.
- Frontend: detail panel adds "View all in this folder" button that
opens a modal listing 20 sessions per page with Show more pagination.
- Modal items reuse _buildHistoryItem with showViewAll:false to avoid
recursive entry points.
Owner
|
Great input — thank you! Nice refactor: extracting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The homepage Resume Conversation list dedups history at 3 sessions per project so the top of the page doesn't get dominated by a single hot folder. But once you want to dig into a specific project's older conversations, there is no drill-down — they're hidden.
This adds a "View all in this folder" action that opens a modal listing the complete history for a single project, paginated.
Changes
Backend (
src/web/routes/session-routes.ts)GET /api/history/sessionsnow accepts:projectKey— restrict to a single projectoffset/limit— paginationSingle-folder mode bypasses the 50-cap and returns
{ sessions, total }.projectKeyis validated against^[A-Za-z0-9_-]+$before any filesystem lookup, so the parameter cannot be used for path traversal.Frontend (
src/web/public/terminal-ui.js,styles.css)projectKeyis present._buildHistoryItemwithshowViewAll: falseto avoid recursive entry points.Test plan
tsc --noEmitpassesnpm run lintpassesnpm run format:checkpassesprojectKey=../../etcare rejected by the regex before reaching the filesystem.