refactor: drop ark-node API (v1) support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
changed the title
spkjp
previously requested changes
Jan 1, 2019
| @@ -18,7 +17,7 @@ public Connection(Map<String, Object> config) { | |||
| this.version = ((int) (config.get("API-Version"))); | |||
| this.client = new Client(config.get("host").toString(), Integer.toString(this.version)); | |||
|
|
|||
| this.api = (T) ((this.version == 1) ? new One(this.client) : new Two(this.client)); | |||
| this.api = (T) new Api(this.client); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| import org.arkecosystem.client.http.Client; | ||
|
|
||
| public class Two extends AbstractAPI { | ||
| public class Api extends AbstractAPI { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
faustbrian
added
Type: Breaking Change
|
The ci/circleci: build job is failing as of 93432f62dd3f8e95311188b28587046ea221e1f3. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
faustbrian
changed the title
faustbrian
changed the title
spkjp
approved these changes
Jul 8, 2019
spkjp
pushed a commit
that referenced
this pull request
Oct 10, 2019
* refactor: drop ark-node API (v1) support (#24) * release: 0.1.4 (#43) * chore: setup probot/stale configuration (#44) * chore(readme): add lead maintainer information (#45) * ci: setup github action workflow for testing * ci: remove old CircleCI configuration * ci: adjust job triggers (#53) * ci: report coverage to codecov (#54) * chore(deps): add renovate.json (#55) * chore(deps): update dependency gradle to v5
kristjank
pushed a commit
that referenced
this pull request
Feb 12, 2020
* refactor: drop ark-node API (v1) support (#18) * fix: wrong reference * refactor: remove all generic and abstract leftovers * fix: add return type * fix : typos (#42) * fix: typos * fix: typos * refactor: remove version argument remains * fix: remove duplicate function definition * chore: update deps * feat: crypto endpoint (#47) * feat: add missing api endpoints (#50) * chore(deps): update dependency gradle to v5 (#57) * refactor: drop ark-node API (v1) support (#24) * release: 0.1.4 (#43) * chore: setup probot/stale configuration (#44) * chore(readme): add lead maintainer information (#45) * ci: setup github action workflow for testing * ci: remove old CircleCI configuration * ci: adjust job triggers (#53) * ci: report coverage to codecov (#54) * chore(deps): add renovate.json (#55) * chore(deps): update dependency gradle to v5 * chore: add spotless plugin (#59) * feat: implement 2.6 endpoints (#61) * chore: spotless plugin (#73) * chore: spotless plugin * chore: spotless plugin upgrade to 3.27.1 * fix: in locks * feat: added a task to build standalone jars (#82) * style: spotless apply * chore: gradle updates * test: true peer change * Revert "test: true peer change" This reverts commit 96e4aa0. * chore: changelog info Co-authored-by: Jolan <mc-somango@live.fr> Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com> Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com> Co-authored-by: Edgar Goetzendorff <hello@dated.fun> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: KovacZan <39158639+KovacZan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be tagged as the first major release.