Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : typos #42

Merged
merged 2 commits into from
Jun 27, 2019
Merged

fix : typos #42

merged 2 commits into from
Jun 27, 2019

Conversation

Highjhacker
Copy link
Contributor

Corrected a few typos where ip should be id in the methods calls.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe: typos

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

@ghost
Copy link

ghost commented Jun 27, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Jun 27, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Jun 27, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@kristjank kristjank merged commit 682b877 into ArkEcosystem:develop Jun 27, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ItsANameToo ItsANameToo added the Bounty: Tier 6 Awarded for typos, text corrections, dependency updates, etc. This is valued at 0 USD. label Jun 27, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

Your pull request has been merged and marked as tier 6. It will earn you $1 USD.

kristjank pushed a commit that referenced this pull request Feb 12, 2020
* refactor: drop ark-node API (v1) support (#18)

*     fix: wrong reference

* refactor: remove all generic and abstract leftovers

* fix: add return type

* fix : typos (#42)

* fix: typos

* fix: typos

* refactor: remove version argument remains

* fix: remove duplicate function definition

* chore: update deps

* feat: crypto endpoint (#47)

* feat: add missing api endpoints (#50)

* chore(deps): update dependency gradle to v5 (#57)

* refactor: drop ark-node API (v1) support (#24)

* release: 0.1.4 (#43)

* chore: setup probot/stale configuration (#44)

* chore(readme): add lead maintainer information (#45)

* ci: setup github action workflow for testing

* ci: remove old CircleCI configuration

* ci: adjust job triggers (#53)

* ci: report coverage to codecov (#54)

* chore(deps): add renovate.json (#55)

* chore(deps): update dependency gradle to v5

* chore: add spotless plugin (#59)

* feat: implement 2.6 endpoints (#61)

* chore: spotless plugin (#73)

* chore: spotless plugin

* chore: spotless plugin upgrade to 3.27.1

* fix: in locks

* feat: added a task to build standalone jars (#82)

* style: spotless apply

* chore: gradle updates

* test: true peer change

* Revert "test: true peer change"

This reverts commit 96e4aa0.

* chore: changelog info

Co-authored-by: Jolan <mc-somango@live.fr>
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: KovacZan <39158639+KovacZan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 6 Awarded for typos, text corrections, dependency updates, etc. This is valued at 0 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants