Skip to content

Conversation

@alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented May 23, 2023

Summary

https://app.clickup.com/t/861mu7rz7

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley
Copy link
Member Author

@ItsANameToo I'm realising this might cause issues with other projects because the md-lg for @screen won't exist. Is it worth adding to the tailwind config, or shall I keep these styles local to the project, OR shall i change to @media(min-width: 960px)?

@ItsANameToo
Copy link
Member

@alexbarnsley I think we can add it to the tailwind configuration as it doesn't hurt if it exists while it's unused in other projects, and there's more than 1 now that requires it as well

alexbarnsley and others added 3 commits May 23, 2023 15:58
@alexbarnsley alexbarnsley marked this pull request as ready for review May 23, 2023 20:38
@alexbarnsley alexbarnsley requested a review from ItsANameToo as a code owner May 23, 2023 20:38
@alexbarnsley alexbarnsley changed the title refactor: add missing table md lg breakpoints refactor: md lg breakpoints for table & footer May 23, 2023
….com:ArkEcosystem/laravel-foundation into refactor/add-missing-table-md-lg-breakpoints
@ItsANameToo ItsANameToo merged commit 0add057 into main May 24, 2023
@ItsANameToo ItsANameToo deleted the refactor/add-missing-table-md-lg-breakpoints branch May 24, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants